Wire up InferenceController and RolloutExecutor and make the controller API async - #1843
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yushengsu-thu
as code owners
July 28, 2026 12:55
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
August 3, 2026 23:39
b140598 to
0887196
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
2 times, most recently
from
August 4, 2026 00:39
8957d29 to
3b71f64
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
August 4, 2026 06:56
0887196 to
5f089d6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
from
August 4, 2026 06:56
3b71f64 to
cd62224
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
August 10, 2026 06:06
5f089d6 to
1a71cad
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
from
August 10, 2026 06:06
cd62224 to
44bfe59
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
August 10, 2026 16:07
1a71cad to
cc79ac3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
from
August 10, 2026 16:07
44bfe59 to
23c4648
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
August 10, 2026 16:34
cc79ac3 to
8dc50ea
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
2 times, most recently
from
August 12, 2026 02:48
788a07a to
2811f05
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
August 12, 2026 14:31
8dc50ea to
fb28f27
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
from
August 12, 2026 14:31
2811f05 to
20fa50d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
August 13, 2026 06:01
fb28f27 to
ee9ca13
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
2 times, most recently
from
August 14, 2026 04:46
aed6aba to
7848ec1
Compare
Collaborator
|
Could we pull two small, dependency-light fixes forward and place them immediately after #1843, so this prefix can merge without waiting for the full refactor stack?
Ideally these are minimal follow-up commits/PRs directly on top of #1843, and we merge that smaller safe prefix before the remaining #1837 stack. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
August 29, 2026 12:39
04b9e93 to
c442051
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
from
August 29, 2026 12:39
7848ec1 to
16cd06c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
August 31, 2026 23:34
c442051 to
cca973a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
from
August 31, 2026 23:34
16cd06c to
42a5460
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
September 3, 2026 06:02
cca973a to
dafb45b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
from
September 3, 2026 06:02
42a5460 to
0664348
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
September 4, 2026 00:53
dafb45b to
c9b2eba
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
from
September 4, 2026 00:54
0664348 to
56bd9d6
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
September 4, 2026 03:28
c9b2eba to
90a12ad
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
from
September 4, 2026 03:28
56bd9d6 to
5cd7de2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-1
branch
from
September 4, 2026 04:20
90a12ad to
149e93c
Compare
…er API async Squashed from: - Run the inference controller in the driver and the executor as an actor - Await the now-async rollout preparation - Make the whole inference controller API async - Make the async controller surface hold in the migration guide and its test
fzyzcjy
force-pushed
the
tom/refactor-miles/op2-5
branch
from
September 4, 2026 04:20
5cd7de2 to
c8c991e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837